Declared $pid in snapinstall

* Updated Makefile.snaplinux to be more flexible with package names
  * Added bit to set root password in snapinstall

Makefile

@@ -12,11 +12,13 @@ DEPENDS = binutils,coreutils,gzip,perl>=5.20.0,tar
 ARCH = x86_64
 URL = 
 DESC = The Snaplinux package management system
+SNAPVER = 0
 
 ARCHIVE := ''
 SRCDIR := $(PWD)/SRC/snap
 PATCHDIR := $(PWD)/SRC/patches
-VERSION := 0.7-0
+VERSION := $(shell grep 'VERSION =>' SRC/snap/Snap.pm| \
+	sed "s/.*=> '\|',//g")-$(SNAPVER)
 
 include /usr/share/snap/Makefile.snaplinux
 

SRC/snap/Makefile.snaplinux

@@ -9,16 +9,21 @@
 # GNU General Public License for more details.
 
 PWD := $(shell pwd)
-PACKAGE := $(shell echo $(PWD)|sed 's/.*\///')
 SNAPDIR = $(PWD)/SNAP
 ROOT = $(PWD)/ROOT
 
-# This allows the package Makefile to override the name
-# of the package file. Added for the kernel package
-# though could be useful for others
+# This will set PACKAGE only if the package itself has
+# not provided a package name
 
-ifndef SNAP
-SNAP := $(PACKAGE)-$(VERSION).snap
+ifndef PACKAGE
+PACKAGE := $(shell echo $(PWD)|sed 's/.*\///')
+endif
+
+# This defines the name of the package file unless
+# specified
+
+ifndef PKGFILE
+PKGFILE := $(PACKAGE)-$(VERSION).snap
 endif
 
 SNAPINFO = $(SNAPDIR)/snapinfo
@@ -31,7 +36,7 @@ FILES = $(SNAPDIR)/files.tar.gz
 # if we find that not to be supplied we're going to
 # assume that the SRCPKG is the same as the PACKAGE
 
-ifndef SRCPKG)
+ifndef SRCPKG
 SRCPKG := $(PACKAGE)
 endif
 
@@ -41,19 +46,19 @@ ifndef VERSION
 $(error VERSION is not set)
 endif
 
-$(SNAP): $(SNAPINFO) $(FILES)
-	@if [ -f $(SNAP) ]; then \
-		rm -v $(SNAP); \
+$(PKGFILE): $(SNAPINFO) $(FILES)
+	@if [ -f $(PKGFILE) ]; then \
+		rm -v $(PKGFILE); \
 	fi
 
-	@ar cvr $(SNAP) $(SNAPINFO) $(MANIFEST); \
+	@ar cvr $(PKGFILE) $(SNAPINFO) $(MANIFEST); \
 	if [ -f $(USHER) ]; then \
 		chmod +x $(USHER); \
-		ar cvr $(SNAP) $(USHER); \
+		ar cvr $(PKGFILE) $(USHER); \
 	fi; \
-	ar cvr $(SNAP) $(FILES)
+	ar cvr $(PKGFILE) $(FILES)
 
-	@echo "Successfully built $(SNAP)"
+	@echo "Successfully built $(PKGFILE)"
 
 $(SNAPINFO): $(MANIFEST)
 	@>$(SNAPINFO)

SRC/snap/Package.pm

@@ -282,6 +282,87 @@ sub depends {
 	$self->revdeps( $sources, $dependencies );
 	}
 
+sub dump {
+	my $self = shift;
+	my $pid;
+	my $sel;
+	my $cnt;
+	my $stderr;
+	my $stat;
+	local $| = 1;
+
+	if ( $self->{'path'} =~ /^https*:\/\// ) {
+		( my $filename = $self->{'path'} ) =~ s/.*\///;
+
+		Snap->httpget( $self->{'path'}, Snap->PKGDIR
+			. "/$filename", 0644 );
+
+		$self->{'path'} = Snap->PKGDIR . "/$filename";
+		}
+
+	print "Dumping $self->{'name'}=$self->{'version'}\n";
+
+	print "\e[?25l\r";
+
+	eval {
+		my $target = Snap->TARGET ||
+			"$self->{'name'}-$self->{'version'}";
+
+		if ( ! -d $target ) {
+			mkdir( $target );
+			}
+
+		$pid = open3( \*CHLDIN, \*CHLDOUT, \*CHLDERR,
+			"/usr/bin/ar p $self->{'path'} files.tar.gz|"
+			. "tar --no-overwrite-dir --keep-directory-symlink"
+			. " -hzvxf - -C $target" );
+		} || Snap->error( int( $! ), "open3(): /usr/bin/ar: $!" );
+
+	close( CHLDIN );
+
+	$sel = IO::Select->new();
+	$sel->add( *CHLDOUT, *CHLDERR );
+
+	while ( my @fhs = $sel->can_read ) {
+		foreach my $fh ( @fhs ) {
+			if ( eof( $fh ) ) {
+				$sel->remove( $fh );
+
+				next;
+				}
+
+			if ( fileno( $fh ) == fileno( *CHLDOUT ) ) {
+				my $line = <$fh>;
+				( my $file = $line ) =~ s/.*\/|\n$//;
+				chomp( $line );
+				chomp( $file );
+
+				if ( $file ) {
+					$cnt++;
+
+					print "\e[K$file\r";
+					}
+				}
+			elsif ( fileno( $fh ) == fileno( *CHLDERR ) ) {
+				$stderr .= <$fh>;
+				}
+			}
+		}
+
+	close( CHLDOUT );
+	close( CHLDERR );
+
+	waitpid( $pid, 0 );
+	$stat = $? >> 8;
+
+	if ( $stat ) {
+		Snap->error( $stat, "Failed dumping $self->{'name'}:"
+			. " $stderr\e[?25h" );
+		}
+
+	print "\e[K$cnt files extracted\e[?25h\n";
+	}
+
 sub files {
 	my $self = shift;
 	my $opts = shift;
@@ -293,8 +374,13 @@ sub files {
 		my $stdout;
 		my $stderr;
 		my $stat;
-		my $pid = open3( \*CHLDIN, \*CHLDOUT, \*CHLDERR,
-			"/usr/bin/ar p $self->{'path'} manifest" );
+		my $pid;
+
+		eval {
+			$pid = open3( \*CHLDIN, \*CHLDOUT, \*CHLDERR,
+				"/usr/bin/ar p $self->{'path'} manifest" );
+			} || Snap->error( int( $! ), "open3(): /usr/bin/ar:"
+				. " $!" );
 
 		close( CHLDIN );
 

SRC/snap/Snap.pm

@@ -7,7 +7,7 @@ use Snap::Commands;
 use Snap::Package;
 use Snap::Sources;
 
-use Fcntl;
+use Fcntl qw( :flock );
 use IPC::Open3;
 use IO::Socket::INET;
 use Digest::SHA qw( sha256_hex );
@@ -89,7 +89,7 @@ use constant VERFILE => eval {
 		}
 	};
 use constant {
-	VERSION => '0.7',
+	VERSION => '0.11',
 	SNAPDIR => TARGET . '/var/lib/snap',
 	PKGDIR => TARGET . '/var/lib/snap/packages',
 	INSTDIR => TARGET . '/var/lib/snap/installed',
@@ -105,6 +105,7 @@ use constant SNAPVER => eval {
 
 	return( $version );
 	};
+use constant LOCKFILE => '/var/lock/snap';
 
 ############################################################
 #
@@ -114,6 +115,17 @@ use constant SNAPVER => eval {
 
 $0 =~ s/.*\///;
 
+############################################################
+#
+# Exit unless we can get exclusive lock
+#
+############################################################
+
+open( LOCK, '>', LOCKFILE ) || Snap->error( int( $! ), "open(): "
+	. LOCKFILE . ": Unable to open lock file" );
+flock( LOCK, LOCK_EX|LOCK_NB ) || Snap->error( int( $! ), "flock(): "
+	. LOCKFILE . ": Unable to lock file" );
+
 ############################################################
 #
 # Make sure we bring back the cursor if we're killed
@@ -832,7 +844,7 @@ sub virtfs {
 		my $stat = 0;
 		my $pid;
 
-		if ( ! -f $virtfs->{$fs}{'dir'} ) {
+		if ( ! -d $virtfs->{$fs}{'dir'} ) {
 			next;
 			}
 

SRC/snap/snap

@@ -6,15 +6,6 @@ use warnings;
 use Snap;
 use Data::Dumper;
 
-############################################################
-#
-# setup() will give the user the option to create the files
-# and directories needed for snap to function
-#
-############################################################
-
-setup();
-
 my $command = shift( @ARGV );
 my $conf = readconf();
 my $commands = Snap::Commands->new();
@@ -23,9 +14,15 @@ my $sources = Snap::Sources->new( $conf->{'sources'} );
 if ( $ARGV[0] && $ARGV[0] eq '-h' ) {
 	$commands->commandhelp( $command );
 	}
-elsif ( $command eq 'genpkg' ) {
+elsif ( $command eq 'dump' ) {
+	print "\n";
+
 	foreach my $arg ( @ARGV ) {
-		genpkg( $arg );
+		my $package = Snap::Package->new( $arg );
+
+		$package->dump();
+
+		print "\n";
 		}
 	}
 elsif ( $command eq 'files' ) {
@@ -61,11 +58,15 @@ elsif ( $command eq 'files' ) {
 
 	print "\n";
 	}
+elsif ( $command eq 'genpkg' ) {
+	foreach my $arg ( @ARGV ) {
+		genpkg( $arg );
+		}
+	}
 elsif ( $command eq 'help' ) {
 	$commands->help();
 	}
 elsif ( $command eq 'info' ) {
-
 	print "\n";
 
 	foreach my $arg ( @ARGV ) {
@@ -104,6 +105,8 @@ elsif ( $command eq 'install' ) {
 	my $bytes = 0;
 	my $virtfs = 0;
 
+	setup();
+
 	foreach my $attrib ( @attribs ) {
 		if ( $string =~ /$attrib\s*:\s*(\S+)/ ) {
 			$opts->{$attrib} = $1;
@@ -331,6 +334,8 @@ elsif ( $command eq 'list' ) {
 	print "\n";
 	}
 elsif ( $command eq 'refresh' ) {
+	setup();
+
 	print "\n";
 
 	$sources->refresh();
@@ -361,6 +366,8 @@ elsif ( $command eq 'reinstall' ) {
 	my $packages = [];
 	my $virtfs = 0;
 
+	setup();
+
 	$sources->readpkgs();
 
 	print "\n";

SRC/snap/snapinstall

@@ -84,6 +84,17 @@ foreach my $package ( @$packages ) {
 	$package->install();
 	}
 
+if ( $virtfs ) {
+	my $pid;
+
+	if ( $pid = fork() ) {
+		waitpid( $pid, 0 );
+		}
+	else {
+		exec( "chroot " . Snap->TARGET . " passwd" );
+		}
+	}
+
 virtfs( 'umount' );
 
 print "\n";